Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
P parabix-devel
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cameron
  • parabix-devel
  • Merge requests
  • !76

Open
Created Jul 27, 2024 by jma246@jma246
  • Report abuse
Report abuse

NFD Insertion Bixnum creation

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

In nfd.cpp, in creating the NFD Insertion BixNumCCs, two unicode sets are pushed to the BixNumCCs variable every iteration of the loop: i.e., for each character detected as being a target for the NFD transform. Despite this, only the first two unicode sets are ever accessed. I believe the two sets being pushed were accidentally included in the scope of the for loop, instead of just before it, so I moved them outside the loop.

Edited Jul 28, 2024 by jma246
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: nfd-canonical-ordering