Skip to content

GitLab

Merged
Created by sla489@sla489Contributor

Small fixes

Hi there,

I'm a student in CMPT479. I ran into a couple small issues building Parabix and I thought I would send these fixes along in case you wanted any of them. Hope you don't mind :)

The fixes are:

  • Use the <llvm/TargetParser/Triple.h> header with LLVM 16.0.0+ instead of <llvm/ADT/Triple.h> which was deprecated in LLVM 16.0.0.
  • Add a few apparently missing headers.
  • Declare mmap/munmap/madvise with C linkage in the MMap source kernel. glibc declares C functions noexcept(true) when __cplusplus, and this was causing these functions to fail to match the FunctionTypeBuilder template. I am assuming C linkage is what CBuilder::LinkFunction expects.

With these changes I got a clean build against LLVM 17.0.1 and all tests passed. The three above items are each committed separately in case you want to cherry-pick some of them.

Thanks!